Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esmeta doesn’t support ~~ in grammar #145

Closed
mathiasbynens opened this issue May 26, 2023 · 1 comment
Closed

esmeta doesn’t support ~~ in grammar #145

mathiasbynens opened this issue May 26, 2023 · 1 comment

Comments

@mathiasbynens
Copy link

See tc39/ecma262#2418 (comment). As part of this patch, we define a grammar that includes ~~:

      <emu-grammar type="definition">
        ClassSetReservedDoublePunctuator :: one of
          `&amp;&amp;` `!!` `##`
          `$$` `%%` `**`
          `++` `,,` `..`
          `::` `;;` `&lt;&lt;`
          `==` `&gt;&gt;` `??`
          `@@` `^^` `&grave;&grave;`
          `~~`
      </emu-grammar>

It seems esmeta doesn’t like this for some reason. The check fails: https://github.com/tc39/ecma262/actions/runs/5088350689/jobs/9144652112?pr=2418#step:7:1

Run "${ESMETA_HOME}"/bin/esmeta tycheck -status -tycheck:log -tycheck:ignore=esmeta-ignore.json
========================================
 extract phase
----------------------------------------
[ESMeta v0.3.0] [Parser (List[spec.Production])] [2[8](https://github.com/tc39/ecma262/actions/runs/5088350689/jobs/9144652112?pr=2418#step:7:9).[12](https://github.com/tc39/ecma262/actions/runs/5088350689/jobs/9144652112?pr=2418#step:7:13)] failure: end of input expected

          `~~`
           ^
Error: Process completed with exit code 1.

@bakkot said:

No idea what's up with that one; probably an esmeta bug. We'll turn the check off or fix esmeta before merging

It would be great if this could be fixed in esmeta.

@jhnaldo
Copy link
Contributor

jhnaldo commented May 27, 2023

Hi, @mathiasbynens. Thanks for your kind report on the bugs in the current version of ESMeta.
Since I fixed this issue in #146, I closed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants