bugfix: Issue #34 #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance we can bump this? Ran into the exact same issue, would love to be able to update. |
|
Would love to see this acknowledged by the repo owner |
bellydrum
reviewed
Nov 25, 2024
| return false; | ||
| } | ||
| const isCloseTag = closeTagExp.test(tag); | ||
| const [, nodeName] = tag.match(nodeNameExp) || []; | ||
| const isElementClosedByTag = isCloseTag && element.nodeName === nodeName; | ||
|
|
||
| return isElementClosedByTag || element.isSelfCloseTag || element.nodeType === NodeType.text; | ||
| // condition is used for reducing the complexity | ||
| const condition = [ |
There was a problem hiding this comment.
Not to be a golfer but we might as well condense it further
return [
isElementClosedByTag,
element.isSelfCloseTag,
element.nodeType === NodeType.text,
].some(Boolean)
However, removing this change entirely might make your PR more likely to be accepted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeError: Cannot read properties of null (reading 'isSelfCloseTag')
Fix and test