Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irc: Fix random UnicodeDecodeErrors #570

Merged
merged 1 commit into from
Dec 28, 2015
Merged

irc: Fix random UnicodeDecodeErrors #570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions errbot/backends/irc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,11 @@ def __init__(self,
super().__init__([(server, port, password)], nickname, username, reconnection_interval=reconnect_on_disconnect)

def connect(self, *args, **kwargs):
# Decode all input to UTF-8, but use a replacement character for
# unrecognized byte sequences
# (as described at https://pypi.python.org/pypi/irc)
self.connection.buffer_class.errors = 'replace'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perlop Would you find this sufficient? I realize that your issue #569 suggested that all input that is impossible to decode should be ignored -- this seems like a bit more robust solution.


connection_factory_kwargs = {}
if self.use_ssl:
import ssl
Expand Down