Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Dockerfile and add proper stop signal #1613

Merged
merged 2 commits into from
Nov 25, 2022
Merged

Conversation

duhow
Copy link
Contributor

@duhow duhow commented Oct 24, 2022

Recovering some changes from #1604 without major changes.

  • Easy way to define extra dependencies for Errbot with INSTALL_EXTRAS (irc, xmpp, telegram, others)
  • Define BASE_IMAGE argument to change base image at all stages
  • Stop errbot with SIGINT signal (actual shutdown of application)

@sijis sijis merged commit fd8ce05 into errbotio:master Nov 25, 2022
@duhow duhow deleted the dockerfile-2 branch November 25, 2022 07:46
sijis added a commit to sijis/errbot that referenced this pull request Jan 1, 2024
* Rework Dockerfile and add proper stop signal

* docs: add info to CHANGES

Co-authored-by: Sijis Aviles <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants