Feature: plugins detection using entrypoints #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijis
changed the title
sijis
changed the title
sijis
changed the title
sijis
added a commit
to sijis/errbot
that referenced
this pull request
Jan 1, 2024
* feat: add entrypoint plugin lookup * feat: add entrypoint plugins * feat: add entrypoint plugin for backends * fix: ensure cli uses entrypoints to list backend plugins * refactor: use importlib instead of pkg_resources * fix: ensure plugin lookup works for py37 * test: basic entrypoint check * docs: refactor installing plugins section * docs: add info on using entrypoints * docs: add info to CHANGES
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature should allow plugins to be detected using entrypoints when installed via pip.
The entrypoints are
errbot.plugins- normal botcmd pluginserrbot.backend_plugins- plugins related to communications systems (Slack, Gitter, etc)A package would need to include this snippet in their
setup.pyto work.Using, https://github.com/errbotio/err-helloworld as an example, we need to add
I would suggest, plugins use the naming convention of
errbot-plugin-$pluginName