Reload all repo plugins when updating a repo #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this reloading all the plugins found in a specific repo or is it reloading all the plugins loaded in errbot? |
|
Just the ones in a specific repository |
|
So in this scenario, a repo has multiple plugins in it, correct? |
Yes, that's correct. In my case, multiple |
`get_plugin_by_path` would only return the first plugin encountered in a repository. This change adds the method `get_plugins_by_path` which yields plugins as they are found. For backwards compatibility, I have not deleted the original `get_plugin_by_path` method, lest anyone use that method directly outside of this package.
sijis
approved these changes
Jul 12, 2021
|
Thank you for these fixes. |
sijis
added a commit
that referenced
this pull request
Jun 11, 2022
* Reload all plugins in a repo `get_plugin_by_path` would only return the first plugin encountered in a repository. This change adds the method `get_plugins_by_path` which yields plugins as they are found. For backwards compatibility, I have not deleted the original `get_plugin_by_path` method, lest anyone use that method directly outside of this package. * docs: Add fixes to CHANGES Co-authored-by: Sijis Aviles <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_plugin_by_pathwould only return the first plugin encountered in arepository. This change adds the method
get_plugins_by_pathwhich yieldsplugins as they are found.
For backwards compatibility, I have not deleted the original
get_plugin_by_pathmethod, lest anyone use that method directly outside ofthis package.