-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yapsictomy - part 1: botplugins and flows #1219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned gbin
May 20, 2018
ghost
added
the
in progress
label
May 20, 2018
gbin
changed the title
Yapsictomy - part 1
Yapsictomy - part 1: the botplugins and flows
May 20, 2018
gbin
changed the title
Yapsictomy - part 1: the botplugins and flows
Yapsictomy - part 1: botplugins and flows
May 20, 2018
LGTM. Is the plan for this to be a beta release, maybe 6.0? |
This is 6.0. we will have a beta for a while ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dealing with plugins and flows.
The added code is all modern, typed, Python 3.7 with backported dataclasses for 3.6-.
There are still a bit of wobbling between path as str and Path, name vs PluginInfo etc... I expect future small refactoring cleanup PRs to simplify those easily.
Note: The backends are still loaded from Yapsy. This will be addressed in another PR.