Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yapsictomy - part 1: botplugins and flows #1219

Merged
merged 18 commits into from
May 23, 2018
Merged

Yapsictomy - part 1: botplugins and flows #1219

merged 18 commits into from
May 23, 2018

Conversation

gbin
Copy link
Member

@gbin gbin commented May 20, 2018

This is dealing with plugins and flows.

The added code is all modern, typed, Python 3.7 with backported dataclasses for 3.6-.

There are still a bit of wobbling between path as str and Path, name vs PluginInfo etc... I expect future small refactoring cleanup PRs to simplify those easily.

Note: The backends are still loaded from Yapsy. This will be addressed in another PR.

@ghost ghost assigned gbin May 20, 2018
@ghost ghost added the in progress label May 20, 2018
@gbin gbin changed the title Yapsictomy - part 1 Yapsictomy - part 1: the botplugins and flows May 20, 2018
@gbin gbin changed the title Yapsictomy - part 1: the botplugins and flows Yapsictomy - part 1: botplugins and flows May 20, 2018
@andrewthetechie
Copy link
Contributor

andrewthetechie commented May 22, 2018

LGTM. Is the plan for this to be a beta release, maybe 6.0?

@gbin-argo
Copy link
Contributor

This is 6.0. we will have a beta for a while ;)

@gbin-argo gbin-argo merged commit 9a03b72 into master May 23, 2018
@ghost ghost removed the in progress label May 23, 2018
@sijis sijis deleted the yapsictomy branch January 13, 2020 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants