Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This adds threading support officially. #1057

Merged
merged 4 commits into from
Jul 18, 2017
Merged

This adds threading support officially. #1057

merged 4 commits into from
Jul 18, 2017

Conversation

gbin
Copy link
Member

@gbin gbin commented Jul 4, 2017

It is only implemented on Slack at the moment.

  • adds a parent field to Message signaling to backends that it is a threaded
    response.
  • retrofit in_reply_to as a signal to thread by putting this message as
    parent without changing the frm/to behavior.
  • adds an optional threaded boolean for the build_reply & co that needs
    to be implemented by the backends (similar category as private).

gbin added 2 commits July 4, 2017 21:34
It is only implemented on Slack at the moment.

- adds a parent field to Message signaling to backends that it is a threaded
response.
- retrofit in_reply_to as a signal to thread by putting this message as
parent without changing the frm/to behavior.
- adds an optional threaded boolean for the build_reply & co that needs
to be implemented by the backends (similar category as private).
gbin-argo and others added 2 commits July 5, 2017 17:07
Similar to DIVERT_TO_PRIVATE to force some commands into a thread so it
is less noisy on chat.
@sijis
Copy link
Contributor

sijis commented Jul 7, 2017

I'll look at this more closely over the weekend. I'm not 100% familiar with the threading model, however, if you can show a couple of example usages that would be great!

@gbin
Copy link
Member Author

gbin commented Jul 7, 2017

@sijis It allows you to start message threads like this instead of a standard response:
image

It did this just by supplying the old in_reply_to parameter here:
https://github.com/gbin/err-standup/blob/master/standup.py#L176

You can retrofit this feature to existing commands also by tweaking the config and add to config.py:

DIVERT_TO_THREAD = ('help',)

This is similar to DIVERT_TO_PRIVATE but for THREADS.

I'll do a pass on documenting all that on another PR once we agree on the API.

@sijis
Copy link
Contributor

sijis commented Jul 8, 2017

Ahhh! I was thinking python threads.
I like that this feature being added. Again I'll try and poke at this and provide any feedback.

@gbin gbin merged commit 46302b0 into master Jul 18, 2017
@gbin
Copy link
Member Author

gbin commented Jul 18, 2017

I timeouted on this, merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants