-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This adds threading support officially. #1057
Conversation
It is only implemented on Slack at the moment. - adds a parent field to Message signaling to backends that it is a threaded response. - retrofit in_reply_to as a signal to thread by putting this message as parent without changing the frm/to behavior. - adds an optional threaded boolean for the build_reply & co that needs to be implemented by the backends (similar category as private).
Similar to DIVERT_TO_PRIVATE to force some commands into a thread so it is less noisy on chat.
I'll look at this more closely over the weekend. I'm not 100% familiar with the threading model, however, if you can show a couple of example usages that would be great! |
@sijis It allows you to start message threads like this instead of a standard response: It did this just by supplying the old in_reply_to parameter here: You can retrofit this feature to existing commands also by tweaking the config and add to config.py:
This is similar to DIVERT_TO_PRIVATE but for THREADS. I'll do a pass on documenting all that on another PR once we agree on the API. |
Ahhh! I was thinking python threads. |
I timeouted on this, merged it. |
It is only implemented on Slack at the moment.
response.
parent without changing the frm/to behavior.
to be implemented by the backends (similar category as private).