Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.vale.in and Working with different styles #689

Closed
1 task done
5u623l20 opened this issue Sep 27, 2023 · 3 comments
Closed
1 task done

.vale.in and Working with different styles #689

5u623l20 opened this issue Sep 27, 2023 · 3 comments

Comments

@5u623l20
Copy link

Check for existing issues

  • Completed

Environment

We have been running it for a while and it was running fine but recently I can see that the directory specific rules/styles are not honored properly. I cannot exactly recollect like from which version this stopped working. For the translation directories I can see that all styles are enabled and are reporting errors.

https://github.com/freebsd/freebsd-doc/blob/main/.vale.ini

❯ vale -v vale version master

I have gone through some of the previous issues:
#403
errata-ai/vale-vscode#63
#245

But these are older and our situation worked after these fixes. So I wanted to know whether if there has been a recent changes which might have reintroduced the error?

Describe the bug / provide steps to reproduce it

git clone https://github.com/freebsd/freebsd-doc.git vale .
Precaution it will take 30-40 minutes to complete.

We will see Vale.Spelling errors on the translation documents which are not supposed to happen as those have been disabled.

@jdkato
Copy link
Member

jdkato commented Sep 27, 2023

Nothing should have changed (certainly not deliberately).

Could you name one of the documents that had Vale.Spelling errors?

I tried to reproduce this by running Vale on the translation directories individually (e.g., vale documentation/content/ja) and was not able to.

@5u623l20
Copy link
Author

5u623l20 commented Sep 28, 2023

vale website/content/zh-tw/

vale website/content/zh-cn/

And if I am not mistaken with the problem I think it is the '**' that is creating the problem. It's supposed to mean zero or more but more like it's behaving like 1 or more.

jdkato added a commit that referenced this issue Oct 2, 2023
This changes our underlying glob dependency to address issues with
`**`.

#689.
@jdkato
Copy link
Member

jdkato commented Oct 2, 2023

And if I am not mistaken with the problem I think it is the '**' that is creating the problem. It's supposed to mean zero or more but more like it's behaving like 1 or more.

This is indeed the issue. It should be fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants