move to testing on otp 26, 25, 24

.github/workflows/main.yml

@@ -15,7 +15,7 @@ jobs:
 
     strategy:
       matrix:
-        otp_version: [22, 23, 24, 25]
+        otp_version: [23, 24, 26]
         os: [ubuntu-20.04] # latest only runs >= 24.2
 
     container:

.github/workflows/shelltest.yml

@@ -17,7 +17,7 @@ jobs:
       matrix:
         # TODO: make a batch of tests that runs on nodetool rather
         #       than the new connectivity mechanism
-        otp_version: [24, 25]
+        otp_version: [25, 26]
         os: [ubuntu-latest] # latest only runs >= 24.2
 
     steps:

.github/workflows/wintest.yml

@@ -15,8 +15,7 @@ jobs:
 
     strategy:
       matrix:
-        # Cannot test OTP 21 due to https://bugs.erlang.org/browse/ERL-644 (see also https://github.com/elixir-lang/elixir/issues/7774)
-        otp_version: [22, 23, 24, 25]
+        otp_version: [24, 25, 26]
         os: [windows-latest]
 
     steps:

src/relx.app.src

@@ -5,6 +5,8 @@
   {registered, []},
   {applications, [kernel,
                   stdlib,
-                  bbmustache]},
+                  bbmustache,
+                  sasl,
+                  tools]},
   {licenses, ["Apache-2.0"]},
   {links, [{"Github", "https://github.com/erlware/relx"}]}]}.

src/rlx_assemble.erl

@@ -759,7 +759,7 @@ maybe_check_for_undefined_functions_(State, Release) ->
                     FilterMethod = rlx_state:filter_xref_warning(State),
                     FilteredWarnings = FilterMethod(Warnings),
                     format_xref_warning(FilteredWarnings);
-                {error, _} = Error ->
+                {error, _, _} = Error ->
                     ?log_warn(
                         "Error running xref analyze: ~s", 
                         [xref:format_error(Error)])
@@ -776,13 +776,13 @@ add_project_apps_to_xref(Rf, [AppSpec | Rest], State) ->
     case maps:find(element(1, AppSpec), rlx_state:available_apps(State)) of
         {ok, App=#{app_type := project}} ->
             case xref:add_application(
-                    Rf,
-                    rlx_app_info:dir(App),
-                    [{name, rlx_app_info:name(App)}, {warnings, false}]) 
+                   Rf,
+                   binary_to_list(rlx_app_info:dir(App)),
+                   [{name, rlx_app_info:name(App)}, {warnings, false}])
             of
                 {ok, _} ->
                     ok;
-                {error, _} = Error ->
+                {error, _, _} = Error ->
                     ?log_warn("Error adding application ~s to xref context: ~s",
                               [rlx_app_info:name(App), xref:format_error(Error)])
             end;

src/rlx_util.erl

@@ -104,7 +104,7 @@ parsed_vsn_lt({MMPA, {AlphaA, PatchA}}, {MMPB, {AlphaB, PatchB}}) ->
            PatchA < PatchB))).
 
 %% @doc Generates the correct set of code paths for the system.
--spec get_code_paths(rlx_release:t(), file:name()) -> [filename:filename_all()].
+-spec get_code_paths(rlx_release:t(), file:name()) -> [file:filename_all()].
 get_code_paths(Release, OutDir) ->
     LibDir = filename:join(OutDir, "lib"),
     [filename:join([LibDir, [rlx_app_info:name(App), "-", rlx_app_info:vsn(App)], "ebin"]) ||