More helpful error if file:consult fails with .app #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsloughter
requested changes
Nov 20, 2021
Co-authored-by: Tristan Sloughter <[email protected]>
Co-authored-by: Tristan Sloughter <[email protected]>
|
Thanks again for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion, I've removed the reference to the rebar dependency and it will just print an error message related to the missing .app file. I've also changed the phrasing from "unable to read" to "unable to consult." (given that it's a failure to use
file:consulton the file in question).I'm hoping this is better!
In the meantime, I may dig into the rebar3 code to try and catch this error sooner than later (not sure if I'll have time this weekend).
Response to #892
See previous discussion here: #893