disable html escaping in overlay templates #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mustache template engine escapes HTML entities by default. This is quite annoying since we are not generating HTML pages in a web application. This problem was already referenced in erlware#497. Now that bbmustache supports a way to disable escaping by default, there is no reason not to do it. Additionally, escaping is already disabled in rebar3 templates (see fe8626ff7de635cc84da61b8b3deb553fe9572c9), so having both templating systems behave the same way makes sense.
|
Yup, thanks! I think this is to safe to merge as is, but I'm not sure how all people have been using overlays so worry it might need to be possible to re-enable escaping. |
|
I would merge it. I can't imagine people generate HTML templates with relx more often than regular use cases for that and my bet is that we can treat escaping as a bug. |
|
i had to do something (can't remember what exactly) in my overlays that was related with escaping, can we hold on this one a bit while I find what it is exactly? |
|
@lrascao yea, no problem. |
|
👍 , all good, i remembered what i do in cases where i don't want escaping to happen: i wrap the overlay in triple mustaches: |
lrascao
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mustache template engine escapes HTML entities by default. This is quite
annoying since we are not generating HTML pages in a web application. This
problem was already referenced in
#497. Now that bbmustache supports a way
to disable escaping by default, there is no reason not to do it.
Additionally, escaping is already disabled in rebar3 templates (see
fe8626ff7de635cc84da61b8b3deb553fe9572c9), so having both templating systems
behave the same way makes sense.