Bring back undocumented start/attach extended start script commands #833
Conversation
lrascao
changed the title
|
Cool, so the reason this is a draft is the need for the link to docs? |
priv/templates/extended_bin
Outdated
| start) | ||
| # TODO, add here the right annoying message asking users to consider | ||
| # instead using systemd or some such other init system | ||
| echo "'start' has been deprecated and will be removed in the short-term, please consider <link-to-doc> for alternatives" |
There was a problem hiding this comment.
Should add in that the user should use daemon to get the same result as start and also to check the link to docs for why you should really be using foreground and an init tool. But don't have to mention foreground if we get a link in the docs for this, but do need it to say use daemon instead.
Same for attach, it should say attach is deprecated, use daemon_attach ...
There was a problem hiding this comment.
ok, i'll rephrase this to not require the doc link just now, we can open a new PR to add it later
priv/templates/extended_bin
Outdated
| start) | ||
| # TODO, add here the right annoying message asking users to consider | ||
| # instead using systemd or some such other init system | ||
| echo "'start' has been deprecated and will be removed in the short-term, please consider <link-to-doc> for alternatives" |
There was a problem hiding this comment.
@tsloughter would be nice to have a link-to-doc somewhere, another option is to leave it open for people to dig on their own
There was a problem hiding this comment.
link-to-doc is risky since we don't necessarily commit to super stable doc links with the new site
priv/templates/extended_bin
Outdated
| start) | ||
| # TODO, add here the right annoying message asking users to consider | ||
| # instead using systemd or some such other init system | ||
| echo "'start' has been deprecated and will be removed in the short-term, please consider <link-to-doc> for alternatives" |
There was a problem hiding this comment.
ok, i'll rephrase this to not require the doc link just now, we can open a new PR to add it later
Prints out an annoying message instructing users to consider the alternatives while still supporting these operations. Main intent is to ease adoption of a new version and not force people to go around changing millions of scripts from 'start' to 'daemon'.
lrascao
force-pushed
the
feature/add_undocumented_start_attach_commands
branch
from
be0dcc9 to
6c66d9e
Compare
lrascao
changed the title
Prints out an annoying message instructing users to consider the
alternatives while still supporting these operations. Main intent
is to ease adoption of a new version and not force people to go around
changing millions of scripts from 'start' to 'daemon'.