rebar3_hex_organization: allow building with OTP-25.0-rc1 #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starbelly
approved these changes
Mar 22, 2022
|
Thanks for the contribution! We'll cut a release by tomorrow. ❤️ |
|
Just noting, needed to get in a bug fix and enhancement before publishing :) |
|
Hi @starbelly is it ready for a release? if not, need any help? |
|
@zmstone I think I was waiting on a PR to be merged, but that's not going to happen atm, so I'll cut a release tonight. |
|
@zmstone https://hex.pm/packages/rebar3_hex/7.0.2 released :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to build with OTP-25.0-rc1 throws a warning:
===> Compiling rebar3_hex src/rebar3_hex_organization.erl:391:5: Warning: public_key:ssh_encode/2 is removed; use ssh_file:encode/2 insteadwhich arguably should have been a hard error since the function is gone.
For some reason the ifdef:ery in
rebar3_hex_organization.erldoesn't make the right choice for OTP-25.0-rc1, so I took the opportunity to rewrite it using the standardOTP_RELEASEmacro. With this the build succeeds.