Improve local password collection #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 5, 2021
- Resolves an issue where by if we accept a local password over 32 bytes we'll crash at key generation time. Instead, we now warn if the password is over 32 chars and prompt the user to try again. On the third attempt we throw a provider error. - To go along with the above, we now will warn the user if confirmation of a local password does not match the original entered local password vs immediately throwing, instead the user has 3 attempts to correctly confirm.
starbelly
force-pushed
the
warn-if-passwd-over-32-chars
branch
from
290d3cb to
7a413a9
Compare
|
I will open up a PR to forward port this to master after this is merged. |
ferd
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #256 and #190
time. Instead, we now warn if the password is over 32 chars and prompt the user to try again. On the
third attempt we throw a provider error.
does not match the original entered local password vs immediately throwing, instead the user has 3 attempts
to correctly confirm.