Tweak manifest plugin to return ELP compatible information.

[robertoaloi]

Starting the discussion around the actual format to use in the manifest plugin.

For the time being, instead of returning the raw context, I'm basically adopting the same format previously adopted by the build_info plugin, used by the ELP language server. Using the same format avoids changes to ELP itself.

I am also adding a json format to make it easier for tools to consume the information.

Test Plan

Generate build information for the Erlang LS repo via ELP (internally using the build_info plugin):

elp build-info --project ~/git/github/erlang-ls/erlang_ls --to /tmp/erlang-ls-build

Locally modify ELP to use the experimental manifest plugin instead, then:

elp build-info --project ~/git/github/erlang-ls/erlang_ls --to /tmp/erlang-ls-manifest

Finally compare the two generated files:

diff /tmp/erlang-ls-build /tmp/erlang-ls-manifest

The only difference, for each application, is:

<         "include"
---
>         "include",
>         "src",
>         ""

This should not be an issue, but we can double check that as a follow-up.

[ferd]

Since this provider was marked as experimental I don't see big problems with changing the format.

That none of the tests captured it does point to some of these tests eventually needing some hardening, particularly to get out of experimental mode.

[robertoaloi]

That's exactly the plan. One thing we're considering is if we shouldn't simply output JSON, easier for tools to consume, given that OTP 27 comes with it. Of course we'd have to detect whether the json module is available and bail out if that's not the case.

[tsloughter]

Yes, should output json I think. Or at least take a -o json argument.

[ferd]

"Either upgrade to OTP 27 or newer, or select a different output format." maybe

[robertoaloi]

Fixed the spelling, thanks.

[ferd]

Seems good to me at this point, anything else you wanted on this or it's ready to go?

[robertoaloi]

Ready to go for now.

[robertoaloi]

@ferd Not terribly urgent, but what's the ETA for the next rebar3 release?

[ferd]

Yeah I'm probably due to cut a new one. Will try it this week, next week at the latest.

[ferd]

3.24.0 was just released: https://github.com/erlang/rebar3/releases/tag/3.24.0