Support OTP-26, Deprecate OTP-23 support. #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The two shell tests messing up are currently related to calls in the PC plugin or makefiles that we can tie to erlang/otp#6916 (thanks @starbelly) The mix issue is related to the shards application using invalid type annotations, which the compiler now catches and did not before. I think I'm okay with bypassing them for now and merging and cutting despite the failing checks. CC @tsloughter |
starbelly
approved these changes
May 18, 2023
|
It isn't the PC plugin. it is the Makefile that rebar3 generates for the cmake template. |
kianmeng
added a commit
to kianmeng/docker-erlang-otp
that referenced
this pull request
Jun 23, 2024
Rebar3 3.20.1 official deprecated support for OTP 23. See: - erlang#473 - https://github.com/erlang/rebar3/releases/tag/3.21.0 - erlang/rebar3#2791
kianmeng
added a commit
to kianmeng/docker-erlang-otp
that referenced
this pull request
Jun 23, 2024
Rebar3 3.20.1 official deprecated support for OTP 23. See: - erlang#473 - https://github.com/erlang/rebar3/releases/tag/3.21.0 - erlang/rebar3#2791
kianmeng
added a commit
to kianmeng/docker-erlang-otp
that referenced
this pull request
Jun 23, 2024
Rebar3 3.20.1 official deprecated support for OTP 23. See: - erlang#473 - https://github.com/erlang/rebar3/releases/tag/3.21.0 - erlang/rebar3#2791
kianmeng
added a commit
to kianmeng/docker-erlang-otp
that referenced
this pull request
Jun 23, 2024
Rebar3 3.21.0 officially deprecated support for OTP 23. See: - erlang#473 - https://github.com/erlang/rebar3/releases/tag/3.21.0 - erlang/rebar3#2791
getong
pushed a commit
to erlang/docker-erlang-otp
that referenced
this pull request
Jun 23, 2024
Rebar3 3.21.0 officially deprecated support for OTP 23. See: - #473 - https://github.com/erlang/rebar3/releases/tag/3.21.0 - erlang/rebar3#2791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see how CI goes.