OTP-26-rc1 support: Fix incremental dialyzer usage, and make it even more incremental #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferd
changed the title
ferd
changed the title
ferd
force-pushed
the
incremental-dialyzer-fixes
branch
from
e7ead25 to
400e338
Compare
|
So this always uses incremental on 26+ and has no way to disable it? |
Rather than having a project-local PLT, this mechanism uses a base configuration to start from a shared PLT image, which is then used with the new incremental build mechanism to make a new per-project PLT file, which will then be maintained incrementally. This should speed up per-project first incremental runs after the first ever is done, in line with classic Dialyzer usage.
ferd
force-pushed
the
incremental-dialyzer-fixes
branch
from
0f39ca1 to
2da0779
Compare
It's an option, and defaults to false. |
|
Oh, so |
Yep, the effective check is at rebar3/apps/rebar/src/rebar_prv_dialyzer.erl Line 188 in 7fa21c6 |
tsloughter
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current state of Dialyzer incremental support was added before the code was shipped. There are 3 behaviours that can work:
What we currently have in main for incremental mode is option 1. What Rebar3 did with classical PLTs was in option 3, and saved cross-project build time. It appears that Dialyzer can tolerate receiving an input PLT and an output PLT for incremental builds, which means option 3 ought to be supported, but I don’t want to work at cross purposes with the tools.
This PR switches us to mode 3 and updates the tests to show that support.