Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert ebin_modules to include all beams minus extra_src #1955

Merged
merged 1 commit into from
Nov 24, 2018

Conversation

tsloughter
Copy link
Collaborator

This change broke inclusion of modules that are built straight to beam files and have no .erl file in the src dirs for them.

I don't think the removal of beams that are built from extra src dirs is required though... I kept it there since I'm just reverting to the old functionality, but extra src dir beams aren't built to the ebin dir, so not sure why that is there. Unless we should be building extra src dir files to ebin instead of doing the annoying copying of source files.

@tsloughter tsloughter requested a review from ferd November 24, 2018 19:27
@ferd
Copy link
Collaborator

ferd commented Nov 24, 2018

We needed the extra dir files apart just because they strictly didn’t belong in the final releases. Aside from that that’s all there is to it I think

@tsloughter
Copy link
Collaborator Author

@ferd right but they also aren't in the ebin dir so shouldn't have to filter them.

@tsloughter tsloughter merged commit d50b70a into master Nov 24, 2018
@tsloughter tsloughter deleted the revert-ebin_modules branch January 2, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants