refactor(storage/fs/object): move all implementations into single sto… #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re backed by gcblob
erka
added a commit
that referenced
this pull request
Jan 7, 2024
* feat(storage/gcs): add support for Google Cloud Storage fixes flipt-io#2288 * address PR feedback, cleanup tests and better context for blob FS * cleanup docs * fix tests and schema * Update internal/config/storage.go Co-authored-by: Mark Phelps <[email protected]> * cleanup go.mod * Update internal/storage/fs/object/blob/blob_fs.go Co-authored-by: George <[email protected]> * remove unused import * Update internal/storage/fs/object/blob/blob_fs_test.go Co-authored-by: George <[email protected]> * fix test prefix * remove prefixedBucket * refactor(storage/fs/object): move all implementations into single store backed by gcblob (#9) Co-authored-by: George MacRorie <[email protected]> * fix linter issue and remove panic call * cleanup * added new integration test to github actions and improve test coverage --------- Co-authored-by: Mark Phelps <[email protected]> Co-authored-by: George <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…re backed by gcblob