Skip to content

Commit

Permalink
When trying out the web page in https://www.browserstack.com
Browse files Browse the repository at this point in the history
by using their Iphone, I got an error

"TypeError: Attempting to change configurable attribute of unconfigurable property."
Searching Google for the error text led me to:
ariya/phantomjs#13895
Just speculating that name() could be causing the error so
I renamed it to parser_name(). There is one more name() function
that has yet to be renamed.
  • Loading branch information
eriksjolund committed Aug 4, 2016
1 parent cece001 commit f85a1b3
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion from_layout/src/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export class App {
this.datafiles_container = datafiles_container;
this.layout_renderers = {};
for (const parser of parsers) {
this.layout_renderers[parser.name()] = parser.parser_func();
this.layout_renderers[parser.parser_name()] = parser.parser_func();
}

for (const layout_creator_class of layout_creator_classes) {
Expand Down
2 changes: 1 addition & 1 deletion from_layout/src/fromcolor_parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import st_image_slicer from './st_image_slicer.js';

export default class {
constructor() {}
static name() { return "fromcolor"; }
static parser_name() { return "fromcolor"; }
static parser_func() {
return function(rendering_data, data_files) {
const data_file = data_files[ rendering_data.data_filename ];
Expand Down
2 changes: 1 addition & 1 deletion from_layout/src/fromgene_parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ function getSlicePromise(gene_name, genehit_cutoff, st_exp_protobuf_file) {

export default class {
constructor() {}
static name() { return "fromgene"; }
static parser_name() { return "fromgene"; }
static parser_func() {
return function(rendering_data, data_files) {
const data_file = data_files[ rendering_data.data_filename ];
Expand Down

0 comments on commit f85a1b3

Please sign in to comment.