Fix

[grooverdan]

few small fixes. Some details in the commit message, email response coming too.

[eriksjolund]

Hi @grooverdan, thanks for reaching out and finding the bugs!

I wonder if you could split out these bug fixes

cp -r mariadb*@.* ~/.config/systemd/user

--volume %h/mariadb-data-unix.%i:/var/lib/mysql:Z

and the same bug fix in [email protected]:

--volume %h/mariadb-data-tcp.%i:/var/lib/mysql:Z   

into a separate PR. I could then merge that PR directly. (If you want to, I could also write the PR).
The reason for separating out those changes is that they are obvious bug fixes.
For the rest of the changes I would need to study them a bit more first.

I think the line

Environment=PODMAN_SYSTEMD_UNIT=%n-%i

is probably correct. At least, it comes
directly from podman systemd generate --template.

[test@laptop ~]$ podman generate systemd --name --new --template nginxtest | grep Environment
Environment=PODMAN_SYSTEMD_UNIT=%n-%i
[test@laptop ~]$ podman generate systemd --name --new --help | grep -- --template
      --template                  Make it a template file and use %i and %I specifiers. Working only for containers
[test@laptop ~]$ podman --version
podman version 4.0.0-rc5
[test@laptop ~]$ 

It would be good to stay as close to the Podman default configuration as possible. Here is an example that shows how Podman 4.0.0-rc5 generates a systemd unit file:

[test@laptop ~]$ podman run --rm -d --name nginxtest docker.io/library/nginx
4f63df20801644739d7be2dabfcdff8f44097bdf42b1814d8d2206954716e4cc
[test@laptop ~]$ podman generate systemd --name --new --template nginxtest
# [email protected]
# autogenerated by Podman 4.0.0-rc5
# Mon Feb 14 14:10:35 CET 2022

[Unit]
Description=Podman container-nginxtest.service for %I
Documentation=man:podman-generate-systemd(1)
Wants=network-online.target
After=network-online.target
RequiresMountsFor=%t/containers

[Service]
Environment=PODMAN_SYSTEMD_UNIT=%n-%i
Restart=on-failure
TimeoutStopSec=70
ExecStartPre=/bin/rm -f %t/%n.ctr-id
ExecStart=/usr/bin/podman run --cidfile=%t/%n.ctr-id --cgroups=no-conmon --rm --sdnotify=conmon --replace -d --name nginxtest-%i docker.io/library/nginx
ExecStop=/usr/bin/podman stop --ignore --cidfile=%t/%n.ctr-id
ExecStopPost=/usr/bin/podman rm -f --ignore --cidfile=%t/%n.ctr-id
Type=notify
NotifyAccess=all

[Install]
WantedBy=default.target
[test@laptop ~]$ podman --version
podman version 4.0.0-rc5
[test@laptop ~]$ 

I understand that the changes you suggest might still be needed. It would be good to try to document the reasons for each change that drift away from the default. Right now I don't have a good understanding of how systemd and podman stops and restart containers. I realize that I need to study this a bit.

In the best of worlds it would be possible to use Quadlet. The advantage is that the config files would be smaller and look cleaner. To use Quadlet I guess one need to stay close to the defaults, though.

When I read
https://docs.podman.io/en/latest/markdown/podman-run.1.html#sdnotify-container-conmon-ignore
--sdnotify=container seems to be the best match as to what we need. As this value is also the default, the --sdnotify option can be left out (just as you have done in this PR).

[grooverdan]

Starting/stopping services - above linked issue.

Environment=PODMAN_SYSTEMD_UNIT given its use in pkg/autoupdate/autoupdate.go as the unit name I suspect the default is wrong, but I've never used the autoupdate.

Quadlet looks really cool. Thanks, I hadn't come across this.

I probably don't have time to neatly reorganise this into multiple PRs or investigate the autoupdate more.