Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sp_QuickieStore: Add more examples to the examples file. #495

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

ReeceGoding
Copy link
Contributor

Closes #489 as best as I could.

The key improvements are:

  • Most sort orders are now in the examples.
  • Every parameter is now in the examples. We were previously missing some very important ones, like how to do version checks.
  • Some lengthy examples added, to reflect how I've used sp_QuickieStore.

The faults in what I'm presenting here are as follows:

  • I couldn't find an excuse to document @sort_order = 'tempdb'. The good news is that all other non-wait sort orders now appear in this example file. A fair few of the wait ones also appear now.
  • I feel that much more could be said about @start_date and @end_date's defaults, but it isn't clear that I understand them. Given how often I use these parameters explicitly, it's worrying that I couldn't find an excuse to write many more examples with them.
  • I don't understand @wait_filter and therefore made no attempt to improve what already existed.
  • I have no experience with the 2022-exclusive features, @workdays, or @escape_character , so what I added was a poor copy and paste job.
  • I don't claim any understanding of why some of the examples in the original had two lines separating them. If it's to denote sections, then we don't we just give up and make this a Markdown file?

Anyway, I think it's still a big improvement!

@erikdarlingdata
Copy link
Owner

@ReeceGoding thanks. I wouldn't worry too much about what you missed in there. I do appreciate any improvements. I will take a stab at this after PASS and add in/standardize more.

@erikdarlingdata erikdarlingdata added enhancement New feature or request sp_QuickieStore For the loving of Query Store labels Oct 28, 2024
@erikdarlingdata erikdarlingdata merged commit a0ec444 into erikdarlingdata:dev Oct 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sp_QuickieStore For the loving of Query Store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants