Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Settings field to rewrite responses and retry requests #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bbiletch
Copy link

@bbiletch bbiletch commented Sep 6, 2019

Includes basic tests.

This should cover #2, though the way WAI handles responses makes modifying the body a bit of a pain.

Copy link
Owner

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little wary of using exceptions for control flow like this, even if the exception shouldn't escape the module).

Can't this be done without exceptions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants