Add locale support #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/src/commonMain/kotlin/io/islandtime/Date.kt # core/src/commonMain/kotlin/io/islandtime/DayOfWeek.kt # core/src/commonTest/kotlin/io/islandtime/MonthTest.kt
# Conflicts: # core/src/commonMain/kotlin/io/islandtime/parser/internal/Parsers.kt
…lt char instead (similar to ICU4J's backward compatibility)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Localetypealias around the platform locale type. The default locale can be acquired in common code using thedefaultLocale()method.It also adds the concept of a
DateTimeTextProvideralong with a default implementation on JVM and Darwin platforms, allowing localized text to be supplied for the day of the week, month, era, AM/PM, and time zone names -- provided that it's available. Differences between platforms should be expected. If something about the stock implementation doesn't cut it, you can roll your ownDateTimeTextProviderand initialize Island Time with it using the newinitialize {}method.Localized text can be parsed, though you should be braced for platform differences.
The localized day of the week is also available, so
Date.startOfWeek(locale)may assume the week starts on "Sunday" in the United States or "Monday" in Germany.Minor breaking changes in the API have been introduced surrounding
DateTimeParserSettings.