Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't compute hashes of empty requests #2630

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Don't compute hashes of empty requests #2630

merged 1 commit into from
Feb 1, 2025

Conversation

bzawisto
Copy link
Contributor

Intermediate hashes of empty requests shouldn't be used for computing final signature. See: ethereum/EIPs#8989

@bzawisto bzawisto added the pectra The Prague/Electra protocol upgrade label Dec 30, 2024
@bzawisto bzawisto marked this pull request as draft December 30, 2024 11:12
@bzawisto bzawisto changed the base branch from master to pectra-devnet-6 January 27, 2025 13:30
@bzawisto bzawisto marked this pull request as ready for review January 27, 2025 13:30
@JacekGlen JacekGlen merged commit 6a8fcf8 into pectra-devnet-6 Feb 1, 2025
3 of 5 checks passed
@JacekGlen JacekGlen deleted the pectra/hashes-of-empty-requests-list branch February 1, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacekGlen JacekGlen JacekGlen approved these changes

Assignees
No one assigned
Labels
pectra The Prague/Electra protocol upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzawisto @JacekGlen