[R4R]Introduce fast finality to erigon #6152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calmbeing
changed the title
AskAlexSharov
approved these changes
Dec 4, 2022
go.mod
Outdated
| google.golang.org/appengine v1.6.7 // indirect | ||
| gopkg.in/inf.v0 v0.9.1 // indirect | ||
| gopkg.in/natefinch/npipe.v2 v2.0.0-20160621034901-c1b8fa8bdcce // indirect | ||
| k8s.io/apimachinery v0.18.3 // indirect |
There was a problem hiding this comment.
why so many k8s deps? Can we avoid them somehow?
AskAlexSharov
requested changes
Dec 4, 2022
| @@ -86,29 +87,44 @@ require ( | |||
| pgregory.net/rapid v0.5.3 | |||
| ) | |||
|
|
|||
| require github.com/ethereum/go-ethereum v1.10.13 // indirect | |||
| replace github.com/tendermint/tendermint => github.com/bnb-chain/tendermint v0.31.12 | ||
| replace ( | ||
| github.com/grpc-ecosystem/grpc-gateway/v2 => github.com/prysmaticlabs/grpc-gateway/v2 v2.3.1-0.20210702154020-550e1cd83ec1 | ||
| github.com/tendermint/tendermint => github.com/bnb-chain/tendermint v0.31.12 |
There was a problem hiding this comment.
can we depend on some sub-set of tendermint instead of whole project?
calmbeing
changed the title
|
This PR is stale because it has been open for 40 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced by bnb-chain/BEPs#126. This PR tries to implement fast finality mechanism for erigon to be fully compatible with bnb-chain