Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RLP: remove allocations, replace buff with pooled buff #12869

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

RLP: remove allocations, replace buff with pooled buff #12869

wants to merge 2 commits into from

Conversation

racytech
Copy link
Contributor

@racytech racytech commented Nov 25, 2024 •
edited
Loading

Preparation for RLP gen package. For now replacing stack allocations with pooled buff, and removing other allocations in RLP encoding logic

@racytech racytech requested review from yperbasis, somnathb1 and AskAlexSharov and removed request for yperbasis November 25, 2024 07:59
AskAlexSharov
AskAlexSharov approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@AskAlexSharov AskAlexSharov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark shows that “stack allocations with pooled buff” - improves speed? Probably reduce?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AskAlexSharov AskAlexSharov AskAlexSharov approved these changes

@somnathb1 somnathb1 Awaiting requested review from somnathb1

@yperbasis yperbasis Awaiting requested review from yperbasis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@racytech @AskAlexSharov