-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make quotations in markdown consistent #32
Make quotations in markdown consistent #32
Conversation
Good contribution. I recommend also making the markdown linting more strict and check for the quotes to be consistent in the future (allow only double quotes). Do you feel like adding this @cassiewallace ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is helpful but should be enforced in the future by markdown linting.
Ack, will do! |
This is actually really important. In past versions of Gatsby (any maybe current), GraphQl queries will fail if there are descrepencies there. Thanks for catching. |
@cassiewallace This may be ingornance, but what exactly is "remark-lint-link-title-style"? |
It's a package that enforces consistency in link and definition titles (NPM link). It is included in some other MD lint presets, such as Alternatively, all of the |
The linting plugin does not work for our scenario. It will only check the titles in links, not in the frontmatter entries. See also this issue. As a side note:
As I do not have write access to this branch: @cassiewallace please remove the commit with the plugin and force push to the branch so the history does not get too cluttered. I will then approve and merge the PR. |
package.json
Outdated
@@ -74,7 +75,8 @@ | |||
}, | |||
"remarkConfig": { | |||
"plugins": [ | |||
"remark-preset-lint-recommended" | |||
"remark-preset-lint-recommended", | |||
"remark-lint-link-title-style" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave it a spin by setting one title to use single quotes and then running npm run lint
. It did not throw an error, thus the plugin does not work for frontmatter.
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mucho ado... ;) Thanks.
No description provided.