This repository has been archived by the owner on Jul 7, 2024. It is now read-only.
forked from libsdl-org/SDL
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericwa
force-pushed
the
windows-highdpi2
branch
from
November 8, 2021 23:53
64b0a21
to
c246994
Compare
ericwa
force-pushed
the
windows-highdpi2
branch
2 times, most recently
from
November 23, 2021 06:41
a09a262
to
f7e89a8
Compare
ericwa
force-pushed
the
windows-highdpi2
branch
3 times, most recently
from
December 4, 2021 21:41
37b4b90
to
3125a0a
Compare
ericwa
force-pushed
the
windows-highdpi2
branch
from
December 12, 2021 19:12
3125a0a
to
2ea2403
Compare
ericwa
force-pushed
the
windows-highdpi2
branch
from
February 6, 2022 07:14
2ea2403
to
3f6d640
Compare
This reverts commit 551c3df.
removes untested code and simplifies diff. First PR will be PMV2 only.
first version of PR will be PMV2 only.
…windows to shrink
…wrong window size
ericwa
force-pushed
the
windows-highdpi2
branch
from
March 10, 2022 07:14
b294970
to
b298013
Compare
Merged into main via libsdl-org#5778 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
--allow-highdpi
on an exe that has "Windows Explorer -> Properties -> Compatibility -> High DPI -> Scaled by Application" set.D3D_ActivateRenderer(renderer);
afterdata->updateSize = SDL_TRUE;
in SDL_render_3d.c issue--allow-highdpi --info all --renderer direct3d11
--allow-highdpi --resizable
, 150% monitor. Ctrl+Enter for fullscreen, then Ctrl+Enter to exit fullscreen. Window is too smallbreak;
at the start of theWM_DPICHANGED
handler--renderer direct3d11
seems to resolve this though? DX9 only?D3D_ActivateRenderer(renderer);
afterdata->updateSize = SDL_TRUE;
in SDL_render_3d.cmain
--allow-highdpi --info all
on 3840x2160 px @ 125% monitor. Alt+Enter gives the following - shouldn't Window size be 3072x1728 points, and the mouse position is also in pixels not points. (global mouse pos is in points though!)--allow-highdpi
, 150% monitor, renders like:data->SetThreadDpiAwarenessContext(DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE_V2);
data->AreDpiAwarenessContextsEqual(DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE_V2, data->GetThreadDpiAwarenessContext())
was returning trueSetThreadDpiAwarenessContext
call toSetProcessDpiAwarenessContext
. Apparently the OpenGL driver (nvidia) needs the process DPI awareness set?Notes:
Testing matrix:
--renderer direct3d11
--renderer direct3d
--renderer opengl