Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role: update roleRepository to use JpaRepository #104

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

GeorgeAnguah
Copy link
Collaborator

update role repository to use the JpaRepository instead of EntityManager.
Added a new roleRepositoryImplV2 to accommodate this change. (can be renamed)

Previous code could be deprecated or removed when this is approved and merge.

Copy link

codesandbox bot commented Dec 10, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
Contributor

Overall Project 89.29% 🍏
Files changed 100% 🍏

File Coverage
RoleServiceImpl.java 100% 🍏

Copy link
Owner

@ericus20 ericus20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericus20 ericus20 merged commit eaff572 into develop Dec 13, 2024
@ericus20 ericus20 deleted the Role_update_roleRepository_to_use_JpaRepository branch December 13, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants