Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Wasm build for .NET 8 #16

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Add a Wasm build for .NET 8 #16

merged 1 commit into from
Aug 9, 2023

Conversation

bricelam
Copy link
Contributor

@@ -105,7 +105,8 @@ jobs:
config:
# Don't forget to add a download-artifact steps in test and publish
- '{ "tfm": "net6.0", "emsdk": "2.0.23" }' # eol: 2024-11-12
- '{ "tfm": "net7.0", "emsdk": "3.1.12" }' # eol: 2023-05-08
- '{ "tfm": "net7.0", "emsdk": "3.1.12" }' # eol: 2024-05-14
- '{ "tfm": "net8.0", "emsdk": "3.1.34" }' # eol: 2026-11-14
Copy link
Contributor Author

@bricelam bricelam Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm following up with the team to make sure this is still the right approach, and to see how likely it this number is to change between now and GA.

bricelam added a commit to bricelam/SQLitePCL.raw that referenced this pull request Jun 30, 2023
@bricelam
Copy link
Contributor Author

(Still waiting to hear back from the .NET Wasm team. They're in the middle of finalizing some decisions for .NET 8.)

@bricelam
Copy link
Contributor Author

bricelam commented Aug 8, 2023

I still haven't heard back from them, but we can probably move forward with this PR. I'll send additional PRs if the version changes before GA. And if they require significant changes for how things work in .NET 8 ...well, we'll cross that bridge when/if we get there.

@bricelam bricelam marked this pull request as ready for review August 8, 2023 18:25
@ericsink
Copy link
Owner

ericsink commented Aug 8, 2023

Sounds good. I'll move forward with this, and the math change, and whatever other pending things I'm forgetting at the moment.

@bricelam
Copy link
Contributor Author

bricelam commented Aug 8, 2023

The only other one on my radar is the TFM warnings.

@bricelam
Copy link
Contributor Author

bricelam commented Aug 8, 2023

Let me know if I can help with any of the work. Always happy to investigate and submit PRs

@ericsink ericsink merged commit 602edc4 into ericsink:master Aug 9, 2023
@bricelam bricelam deleted the wasm8 branch August 9, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants