Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rem sometimes calculates results when it's not supposed to #72

Closed
ericlagergren opened this issue Jan 29, 2018 · 0 comments
Closed

Rem sometimes calculates results when it's not supposed to #72

ericlagergren opened this issue Jan 29, 2018 · 0 comments
Assignees
@ericlagergren

Comments

@ericlagergren
Copy link
Owner

Rem should fail if QuoInt would. This means literally if QuoInt would, not "take QuoInt's failure conditions and generalize them onto Rem." Unfortunately, this means we do need to calculate the quotient and the remainder whenever we call Rem.
@ericlagergren ericlagergren self-assigned this Jan 29, 2018
ericlagergren added a commit that referenced this issue Feb 6, 2018
@ericlagergren
Make sure Rem returns NaN when QuoInt would
7a9b9d0 
Fixes: #72

Former-commit-id: 2517341
ericlagergren added a commit that referenced this issue Feb 6, 2018
@ericlagergren
Make sure Rem returns NaN when QuoInt would
42e5621 
Fixes: #72

Former-commit-id: e769edd5ae63cfc070d64f3f2c8b25aa899b87d6 [formerly 2517341]
Former-commit-id: 7a9b9d0
ericlagergren added a commit that referenced this issue Mar 6, 2018
@ericlagergren
Make sure Rem returns NaN when QuoInt would
bc676be 
Fixes: #72

Former-commit-id: e769edd5ae63cfc070d64f3f2c8b25aa899b87d6 [formerly 2517341]
Former-commit-id: 7a9b9d0
@ericlagergren ericlagergren mentioned this issue Jul 2, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericlagergren ericlagergren

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ericlagergren