-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
verify 32-bit support #46
Comments
Hi Eric Great library. There is a problem with compiling the package on ARM v7 32 bit on this board, which may be related to this issue you opened:
Note that if I cross-compile from a 64-bit linux to target Arm 32bit, it works without issues Let me know if you need more info. Cheers, |
Hmmm. That's fixable, it's just incorrect build tags it seems. Sorry about that, I didn't think of ARM when I set the build constants. Testing compilation is easy enough (I can do it with |
Ran it on a Raspberry Pi. Bunch of tests broke. |
Note: this https://github.com/pguyot/arm-runner-action may help (it uses qemu). I'm using it successfully here: https://github.com/spacemeshos/economics/blob/main/.github/workflows/go.yml (works with arm64, but tests fail with 32 bit) |
Right now the tests are set up for 64-bit platforms (the min/max exponents in the test suite are too large for 32-bit).
All the tests "pass" with
GOARCH=386
to the extent that the arithmetic returns correct results. The signs, exponents, and such are wonky and incorrect because the test suite assumes the results can be larger than they're supposed to be.The text was updated successfully, but these errors were encountered: