Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build against master. #30

Merged
merged 8 commits into from
Mar 27, 2014
Merged

Build against master. #30

merged 8 commits into from
Mar 27, 2014

Conversation

dcbishop
Copy link
Contributor

No description provided.

@dcbishop
Copy link
Contributor Author

It should only be failing to build because Travis-CI is a day out of date with it's rust version: rust-lang/rust#12702

Down to one warning about a non public type Socket_ being exposed via the PollItem struct. Simple squish would be to mark the field as priv but there's probably a better solution since there are other fields in there that should be considered as to their public exposure.

@dcbishop dcbishop mentioned this pull request Mar 25, 2014
@derekchiang
Copy link

Why is the build still failing?

@erickt
Copy link
Owner

erickt commented Mar 27, 2014

I think the build failing was from an out of date nightly. Merging it in, and I'll fix any fallout from it. Thanks!

erickt added a commit that referenced this pull request Mar 27, 2014
@erickt erickt merged commit 2afe46e into erickt:master Mar 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants