-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump handlebars version to ^4.0.0 #142
Conversation
👍 same here, it breaks our build |
Thanks for doing this, I'll have to spend some time to understand the Handlebars v4 changes. In the meantime you can always pass |
@ericf, Any recent news? |
@ericf just want to bump this. We're manually passing in a |
👍 LGTM! |
👍 this would be really helpful |
Oops. Didn't mean to close this temporarily. |
@ericf, would love this one to be merged. Is it still on the radar? |
@ericf let me know if there's any way I can help-- I'd like to get this patched in Sails if possible. |
Thanks @sahat -- don't forget to |
This includes a downstream bump to the uglify version (to 2.4.24) which fixes a vulnerability reported by the Node security project. See https://nodesecurity.io/advisories/uglifyjs_incorrectly_handles_non-boolean_comparisons for more information.
To see the compatibility notes for Handlebars 4, please go to https://github.com/wycats/handlebars.js/blob/master/release-notes.md
Thank you for your time. :)