Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump handlebars version to ^4.0.0 #142

Merged
merged 1 commit into from
Jan 20, 2016
Merged

Bump handlebars version to ^4.0.0 #142

merged 1 commit into from
Jan 20, 2016

Conversation

John-Steidley
Copy link
Contributor

This includes a downstream bump to the uglify version (to 2.4.24) which fixes a vulnerability reported by the Node security project. See https://nodesecurity.io/advisories/uglifyjs_incorrectly_handles_non-boolean_comparisons for more information.

To see the compatibility notes for Handlebars 4, please go to https://github.com/wycats/handlebars.js/blob/master/release-notes.md

Thank you for your time. :)

@stephanbakker
Copy link

👍 same here, it breaks our build

@ericf
Copy link
Owner

ericf commented Sep 8, 2015

Thanks for doing this, I'll have to spend some time to understand the Handlebars v4 changes. In the meantime you can always pass handlebars as a config option to Express Handlebars.

@John-Steidley
Copy link
Contributor Author

@ericf, Any recent news?

@kara-ryli
Copy link

@ericf just want to bump this. We're manually passing in a handlebars config parameter, but our security checks are alerting on handlebars-lang/handlebars.js#1084 and I would love to squelch the false positive.

@chiefy
Copy link

chiefy commented Oct 8, 2015

👍 LGTM!

@andrewpmckenzie
Copy link

👍 this would be really helpful

@John-Steidley
Copy link
Contributor Author

Oops. Didn't mean to close this temporarily.

@stephanbakker
Copy link

@ericf, would love this one to be merged. Is it still on the radar?

@mikermcneil
Copy link

@ericf let me know if there's any way I can help-- I'd like to get this patched in Sails if possible.

@sgress454
Copy link

Thanks @sahat -- don't forget to npm publish as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants