Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add htmlBlockingStrategy to remove dependency on youtubeDataAPIBlockingStrategy #4

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: add htmlBlockingStrategy to remove dependency on youtubeDataAPIBlockingStrategy #4

wants to merge 6 commits into from
+149 −150

Conversation

eric60
Copy link
Owner

@eric60 eric60 commented Oct 11, 2021 •
edited
Loading

Changes

  • Current blocking strategy is YoutubeDataApi blocking strategy

  • New HtmlBlocking strategy can block videos without having to setup a google cloud account and youtube data api key

    • It does this by looking for the category code in the javascript scripts
    • image

  • Credit to Oscar Semec who suggested a code change here

  • to block videos based on innerhtml from the source JavaScript files

  • instead of blocking videos through the Youtube Data API which requires manual and tedious setup for the client

Steps

  • Need to copy and paste Oscar's code into the contentScript.js script to block videos based on the page's html metadata

@eric60 eric60 changed the title feature: replace youtube data api calling with html blocking feature: replace YoutubeDataApi blocking with HtmlBlocking Oct 11, 2021
@eric60 eric60 force-pushed the htmlBlockerRefactor branch from 1b914a4 to 4bf33cb Compare October 11, 2021 18:02
@eric60 eric60 changed the title feature: replace YoutubeDataApi blocking with HtmlBlocking feature: replace YoutubeDataApi blocking strategy with HtmlBlocking Oct 13, 2021
@eric60 eric60 changed the title feature: replace YoutubeDataApi blocking strategy with HtmlBlocking feature: replace YoutubeDataApi blocking strategy with HtmlBlocking strategy Oct 13, 2021
@eric60 eric60 changed the title feature: replace YoutubeDataApi blocking strategy with HtmlBlocking strategy feature: add HtmlBlocking strategy along with YoutubeDataApi blocking strategy Jan 23, 2022
@eric60 eric60 changed the title feature: add HtmlBlocking strategy along with YoutubeDataApi blocking strategy feature: add HtmlBlocking strategy Apr 6, 2022
@eric60 eric60 changed the title feature: add HtmlBlocking strategy feat: add htmlBlocking strategy to remove youtubeDataApiStrategy Dependency Nov 3, 2022
@eric60 eric60 changed the title feat: add htmlBlocking strategy to remove youtubeDataApiStrategy Dependency feat: add htmlBlockingStrategy to remove youtubeDataApiStrategy Dependency Nov 3, 2022
@eric60 eric60 changed the title feat: add htmlBlockingStrategy to remove youtubeDataApiStrategy Dependency feat: add htmlBlockingStrategy to remove youtubeDataApiBlockingStrategy Dependency Nov 3, 2022
@eric60 eric60 changed the title feat: add htmlBlockingStrategy to remove youtubeDataApiBlockingStrategy Dependency feat: add htmlBlockingStrategy to remove the dependency on youtubeDataApiBlockingStrategy Mar 11, 2024
@eric60 eric60 changed the title feat: add htmlBlockingStrategy to remove the dependency on youtubeDataApiBlockingStrategy feat: add htmlBlockingStrategy to remove dependency on youtubeDataAPIBlockingStrategy May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eric60