Fix #5, Changed behaviour of delete key

[wader]

• Changed current delete to CharEOT, added new CharDelete key

wader notes:
Don't expect more char after ex esc rune
Kick reader even if no char is deleted

[wader]

Needs cleanup and can't find the repo where i found this fix. Also i've fixed a bug in the original commit where deleting at the end of the line would cause readline to stop writing outpu at all.

[wader]

Also related wader/readline@2342177 (Support for windows delete key)

[wader]

Rebased on master. Haven't been able to test things as i'm on laptop with no del key, will test later.

Also have to remember what it was that this actually fixed, i think it made the del key work properly in some cases, but it might depend on how the terminal is configured which is confusing. I also had some changes to fix a bug that it introduced (when deleting last on a line when there is no character to delete) related to kick reader. But after rebase on master i see that that stuff has been reworked so maybe it got fixed?

[slingamn]

Yep, got rid of public KickRead in #16 :-)

Sorry, what does EOT stand for? Also, what is the intended change in behavior here?

[wader]

I honestly don't remember what it actually fixed now but i do remember that it had to do with del-key/ctrl-d behavior and that del-key on an empty readline should not exit the prompt. What makes it confusing is that what terminals sends for del-key/ctrl-d seems to differ and is also configurable.

EOT is probably (ASCII?) end-of-transmission in this context.

Will try to find the original commit, maybe that will shine some light also. I mess up so the original author got lost also.

[wader]

The original author is @stdiopt but can't find repo where is originated from :(

[slingamn]

del-key on an empty readline should not exit the prompt.

Thanks, I can reproduce this --- I'll treat this as a bug report and then see how to adapt this patch to achieve the desired outcome.

[wader]

Great!

[slingamn]

I finally understand this patch! I made a minor change, I'll probably merge this soon.

[wader]

Hehe, don't think i remember how it worked anymore :) it usually take some time to get into terminal mode to remember these things.

[slingamn]

This is a pretty good summary FWIW https://gist.github.com/CMCDragonkai/e45d062aad3be6a3be26da76694fdfbf

[wader]

LGTM