-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added readline support #12
added readline support #12
Conversation
Awesome, nice change. So I'm gonna do some work on top of this and ensure that we preserve Windows compat, maybe make this functionality configurable, and will definitely merge it in! |
bump xoxox |
https://github.com/chzyer/readline looks abandoned.
|
I think the main trouble I was having with this pr was just keeping windows+ansi compatibility is hard – if there's a solution/lib/etc that can provide this functionality while keeping those (at the same time, ie ansi on windows) working then I'm happy! |
I took another look at this using until the user presses the enter key. This stops the app from exiting in response to a server-side disconnection (e.g. one caused by the I could try putting together a minimal test case for this and showing it to upstream... |
Not calling |
Was generally behaving when I created this pr, however I haven't touched this in quite a while |
Sorry, I got lazy and was using this as the tracking issue for readline. I opened a real tracking issue at #28 |
This adds readline support, meaning that among other things, your lines don't get cut up if you're typing and a new raw line comes in, arrow keys can be used to edit lines, and history is kept