This repository has been archived by the owner on Jan 4, 2022. It is now read-only.
Fix: Ignore non-existent exclude classes #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
fix/non-existent
branch
from
5297e00 to
64e4a2d
Compare
localheinz
changed the title
localheinz
commented
Sep 19, 2017
| 'Exclude class names need to be specified as existing classes, but "%s" does not exist.', | ||
| \implode('", "', $excludeClassNames) | ||
| )); | ||
| } |
There was a problem hiding this comment.
This should also increase test coverage as this was never tested.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Blocks ergebnis/factory-girl-definition#15.