Hook on finished instead of passed test event

ergebnis · Nov 28, 2023 · 3fc2545 · 3fc2545
1 parent 4d7bf11
commit 3fc2545
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/composer-require-checker.json b/composer-require-checker.json
@@ -1,7 +1,7 @@
 {
   "symbol-whitelist": [
     "PHPUnit\\Runner\\AfterLastTestHook",
-    "PHPUnit\\Runner\\AfterSuccessfulTestHook",
+    "PHPUnit\\Runner\\AfterTestHook",
     "PHPUnit\\Runner\\BeforeFirstTestHook"
   ]
 }
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -18,7 +18,7 @@
       <code>($durationInMilliseconds - $hoursInMilliseconds - $minutesInMilliseconds) / 1_000</code>
     </InvalidOperand>
   </file>
-  <file src="src/Subscriber/TestPassedSubscriber.php">
+  <file src="src/Subscriber/TestFinishedSubscriber.php">
     <InternalClass>
       <code>Metadata\Annotation\Parser\Registry::getInstance()</code>
     </InternalClass>
@@ -34,7 +34,7 @@
       <code>$maximumDuration</code>
     </MixedAssignment>
     <UnusedClass>
-      <code>TestPassedSubscriber</code>
+      <code>TestFinishedSubscriber</code>
     </UnusedClass>
   </file>
   <file src="src/Subscriber/TestPreparedSubscriber.php">

diff --git a/src/Extension.php b/src/Extension.php
@@ -63,7 +63,7 @@ public function bootstrap(
 
             $facade->registerSubscribers(
                 new Subscriber\TestPreparedSubscriber($timeKeeper),
-                new Subscriber\TestPassedSubscriber(
+                new Subscriber\TestFinishedSubscriber(
                     $maximumDuration,
                     $timeKeeper,
                     $collector,
@@ -81,7 +81,7 @@ public function bootstrap(
      */
     final class Extension implements
         Runner\AfterLastTestHook,
-        Runner\AfterSuccessfulTestHook,
+        Runner\AfterTestHook,
         Runner\BeforeFirstTestHook
     {
         private int $suites = 0;
@@ -117,7 +117,7 @@ public function executeBeforeFirstTest(): void
             ++$this->suites;
         }
 
-        public function executeAfterSuccessfulTest(
+        public function executeAfterTest(
             string $test,
             float $time,
         ): void {

diff --git a/src/Subscriber/TestPassedSubscriber.php → src/Subscriber/TestFinishedSubscriber.php b/src/Subscriber/TestPassedSubscriber.php → src/Subscriber/TestFinishedSubscriber.php
@@ -26,7 +26,7 @@
 /**
  * @internal
  */
-final class TestPassedSubscriber implements Event\Test\PassedSubscriber
+final class TestFinishedSubscriber implements Event\Test\FinishedSubscriber
 {
     public function __construct(
         private readonly Duration $maximumDuration,
@@ -35,7 +35,7 @@ public function __construct(
     ) {
     }
 
-    public function notify(Event\Test\Passed $event): void
+    public function notify(Event\Test\Finished $event): void
     {
         $testIdentifier = TestIdentifier::fromString($event->test()->id());