Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Adjust Methods\FinalInAbstractClassRule to ignore Doctrine embeddables and entities #396

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

localheinz
Copy link
Member

This pull request

  • adjusts Methods\FinalInAbstractClassRule to ignore Doctrine entities

Fixes #295.

@localheinz localheinz self-assigned this Nov 8, 2021
@localheinz
Copy link
Member Author

I have no idea how to traverse from a PhpParser\Node\Stmt\ClassMethod to the containing class node - if I did, I could fix this.

🤷‍♂️

@ergebnis-bot
Copy link
Member

Since this pull request has not had any activity within the last 180 days, I have marked it as stale.

I will close it if no further activity occurs within the next 14 days.

@ergebnis-bot
Copy link
Member

Since this pull request has not had any activity within the last 180 days, I have marked it as stale.

I will close it if no further activity occurs within the next 14 days.

@localheinz localheinz reopened this May 1, 2023
@localheinz localheinz force-pushed the fix/final-in-abstract-class branch 3 times, most recently from c5289c2 to a7cf29e Compare December 1, 2024 19:56
@localheinz localheinz marked this pull request as ready for review December 1, 2024 19:56
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.22%. Comparing base (449466b) to head (1a4a3dd).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/Methods/FinalInAbstractClassRule.php 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #396      +/-   ##
============================================
- Coverage     97.31%   97.22%   -0.09%     
- Complexity      190      199       +9     
============================================
  Files            23       23              
  Lines           632      648      +16     
============================================
+ Hits            615      630      +15     
- Misses           17       18       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@localheinz localheinz force-pushed the fix/final-in-abstract-class branch 5 times, most recently from cbfe4b0 to f5ff035 Compare December 1, 2024 20:23
@localheinz localheinz force-pushed the fix/final-in-abstract-class branch from f5ff035 to 1a4a3dd Compare December 1, 2024 20:25
@localheinz localheinz changed the title Fix: Adjust Methods\FinalInAbstractClassRule to ignore Doctrine entities Fix: Adjust Methods\FinalInAbstractClassRule to ignore Doctrine embeddables and entities Dec 1, 2024
@localheinz localheinz merged commit d718342 into main Dec 1, 2024
23 checks passed
@localheinz localheinz deleted the fix/final-in-abstract-class branch December 1, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

abstract Doctrine entities should not require final methods
2 participants