Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build(deps-dev): Bump vimeo/psalm from 3.8.3 to 3.9.3 #194

Merged
merged 2 commits into from
Feb 19, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Feb 19, 2020

Bumps vimeo/psalm from 3.8.3 to 3.9.3.

Release notes

Sourced from vimeo/psalm's releases.

Adjust config flag behaviour for mixed issues

Version 3.9.0 essentially changed the default reporting level for a host of Mixed issues.

In retrospect this was not the best idea – people saw a (non-error-related) number go up (because of all the newly-reported mixed issues), and people don't like numbers going up.

So this reverts that behaviour – any project that had totallyTyped="false" before will show the same errors & info as it did in 3.8.

This also introduces new flag reportMixedIssues (documented here) that allows more fine-grained control than totallyTyped offers.

Fix a few incompatibilities introduced in 3.9.0

Psalm had an existing issue where it failed to detect the bug in the following code:

class A {
  public function __toString() { return (string) rand(0, 10); }
}
function foo(A $a) {
if ($a === "1" || $a === "2") {} // this will never work
}

Fixing this unearthed a few potential bugs added in 3.9.0 – out of an abundance of caution I'm doing another point release.

Allow totallyTyped config flag to work again

This fixes vimeo/psalm#2832

Improve initialisation

Running psalm --init can be confusing for first-timers.

When you run --init in the latest version it will scan your project to figure out the most appropriate starting level (here's an exhaustive list of all the error levels, and what they mean: https://psalm.dev/docs/running_psalm/error_levels/).

Instead of creating a large config file with a lot of issues, Psalm will now just make a note of the error level at the top of the file (this approach is modelled after PHPStan, which has used it for a number of years).

Other features

  • calling assert(...) on an value right after assigning to it cancels out any MixedAssignment issues (#2442)
  • this adds lowercase-string for when you want the type system to enforce a given string's lowercased-ness. Mainly used for Psalm internals.
  • Psalm will now automatically run in multiple processes wherever possible

Bugfixes

  • A few small bugfixes when using --diff mode
  • Fixed an issue when overriding FilterIterator::accept – thanks @weirdan! (#2761)
  • Allow properties with generic types to be initialised to equivalent objects with empty generic params (#2771)
  • Add support for multiple closure params when calling array_map (#2772)
  • Warn about possible paradoxes in assert calls (#2742)
  • Prevent checkstyle being corrupted when using Shepherd - thanks @staabm! (#2778)
  • Improve templating for method calls on objects that implement template params (#2764)
... (truncated)
Commits
  • 2e4154d Add better defaults and documentation
  • c9494c4 Hide mixed issues if totallyTyped="false"
  • 23b9331 Hide mixed errors if your error level is >= 3
  • aea3382 Fix #1555 - allow phantom class constants
  • 520b646 Add suppressMixedIssues config flag to hide mixed issues
  • 87d8947 Fix phpcs
  • eadf2f8 Improve the reported error when a worker crashes
  • 0e23fab Detect bugs similar to that which caused #2832
  • 9230b42 Ors can still be created directly from conditions
  • 6e80887 Use better return type for SimpleXMLElement::offsetGet
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @localheinz.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #194 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #194   +/-   ##
=========================================
  Coverage     84.32%   84.32%           
  Complexity      138      138           
=========================================
  Files            22       22           
  Lines           453      453           
=========================================
  Hits            382      382           
  Misses           71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9b5c8f...ca87665. Read the comment docs.

@dependabot-preview
Copy link
Contributor Author

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@localheinz localheinz self-assigned this Feb 19, 2020
@localheinz localheinz self-requested a review February 19, 2020 09:45
@dependabot-preview dependabot-preview bot merged commit 07e755f into master Feb 19, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/composer/vimeo/psalm-3.9.3 branch February 19, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant