-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure slashes and UTF-8 characters stay unescaped #995
Conversation
Codecov Report
@@ Coverage Diff @@
## main #995 +/- ##
============================================
+ Coverage 87.04% 87.17% +0.13%
Complexity 57 57
============================================
Files 4 4
Lines 193 195 +2
============================================
+ Hits 168 170 +2
Misses 25 25
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Closing in favour of #1056. |
@localheinz I'm happy to rebase these changes and make them work with the latest version if you'd like. I'll hold off doing that for now though, as GitHub will orphan the branch from this pull request if I force-push while the pull request is closed (and I don't have sufficient permission here to re-open this pull request). |
This pull request ensures that slashes and UTF-8 strings are always unescaped in
composer.json
. The underlying formatting tool correctly detects if the source file already has escaped slashes and/or escaped UTF-8 characters and produces output to match this. However, as seen in #965, this is not always expected behaviour. This pull request applies an opinionated stance to ensure that formatting remains consistent across projects.Note that the underlying library that does formatting detection is working correctly.
Fixes #965