Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Sort scripts-descriptions #89

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

localheinz
Copy link
Member

This PR

  • adjusts the ConfigHashNormalizer to also sort the scripts-descriptions section

Fixes #88.

💁‍♂️ The only concern I have is that we now have a different kind mismatch between how scripts and scripts-descriptions are sorted.

@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #89 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #89   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity       74     74           
=======================================
  Files             7      7           
  Lines           275    275           
=======================================
  Hits            275    275
Impacted Files Coverage Δ Complexity Δ
src/Normalizer/ConfigHashNormalizer.php 100% <ø> (ø) 7 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c81b21...bc79f71. Read the comment docs.

@localheinz localheinz merged commit cd7c78c into master Oct 10, 2018
@localheinz localheinz deleted the feature/scripts-descriptions branch October 10, 2018 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant