Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not attempt to fetch and modify properties of something that isn't an object #87

Merged
merged 2 commits into from
Oct 9, 2018

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Oct 9, 2018

This PR

  • asserts that normalizers skip normalization when json_decode()ed data is not an object
  • skips normalization when json_decode()ed data is not an object

@localheinz localheinz added the bug label Oct 9, 2018
@localheinz localheinz self-assigned this Oct 9, 2018
@codecov
Copy link

codecov bot commented Oct 9, 2018

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #87   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity       69     74    +5     
=======================================
  Files             7      7           
  Lines           264    275   +11     
=======================================
+ Hits            264    275   +11
Impacted Files Coverage Δ Complexity Δ
src/Normalizer/VersionConstraintNormalizer.php 100% <100%> (ø) 10 <0> (+1) ⬆️
src/Normalizer/ConfigHashNormalizer.php 100% <100%> (ø) 7 <0> (+1) ⬆️
src/Normalizer/PackageHashNormalizer.php 100% <100%> (ø) 10 <0> (+1) ⬆️
src/Normalizer/BinNormalizer.php 100% <100%> (ø) 6 <0> (+1) ⬆️
src/Normalizer/ComposerJsonNormalizer.php 100% <100%> (ø) 5 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c28f2e9...b3c12a3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant