Fix validate sub-command after normalizer failure

[guilliamxavier]

This PR

• fixes that the sub-commands were exiting instead of returning the status code
• removes the --strict option from the post-failure call to validate, to avoid validate command: with --no-check-publish, adding --strict makes warnings disappear from output composer/composer#8602 (and its linked issues)
• removes the --no-check-publish option from the post-failure call to validate, because "publish errors" are (strict) schema violations
• makes sure the normalize command returns 1 rather than 0 or 2 when it failed because of schema errors

Related to #349 (part of; doesn't address the question of relaxing validation in the normalizer).
Related to #25.

[guilliamxavier]

Note: The order of commits isn't completely logical. Here's a better recap (omitting static analysis noise):

1. Add a new assertion (in existing test) that "The property name is required" is present in the error output => fails.
2. Remove the --strict option from the call to composer validate => the new assertion now passes (and will keep passing for all the below), but the existing assertion that the exit code is 1 now fails because it is now 0.
3. Remove the --no-check-publish option from the call to composer validate => publish errors are now displayed as errors (rather than mixed with warnings), but the exit-code assertion still fails, though differently: it is now 2.
4. Replace return $this->validateComposerFile(/*...*/); with $this->validateComposerFile(/*...*/); return 1; => unexpectedly, the exit-code assertion still fails as "expected 1, actual 2".
5. Disable auto-exit for running sub-commands => the exit-code assertion now passes (all tests pass).

Do you want me to reorder and force-push?

Update: done (see below)

[codecov]

Codecov Report

Merging #352 into master will decrease coverage by 0.93%.
The diff coverage is 78.57%.

@@             Coverage Diff              @@
##             master     #352      +/-   ##
============================================
- Coverage     87.43%   86.50%   -0.94%     
- Complexity       38       40       +2     
============================================
  Files             4        4              
  Lines           191      200       +9     
============================================
+ Hits            167      173       +6     
- Misses           24       27       +3     

Impacted Files	Coverage Δ	Complexity Δ
src/Command/NormalizeCommand.php	90.60% <78.57%> (-1.26%)	35.00 <2.00> (+2.00)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f64d3ac...014bb84. Read the comment docs.

[guilliamxavier]

Heads-up: I went ahead and reordered the commits as proposed (and squashed static analysis noise into the corresponding commit). But now some checks are failing:

• yamllint: because this project needs to Synchronize with Fix: Consistently quote strings in YAML files php-package-template#388
• codecov: I guess because of the introduced BC layer for symfony/console < 3.1 and only one branch is tested...

[localheinz]

@guilliamxavier

Apologies again for the delay - I've started work on this, as I have had a few ideas around it!

I'll keep you posted!

🤓

[localheinz]

@guilliamxavier

Thank you for your contribution, but I have taken a different approach in #416.