Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove unused test facilities related to removed file argument #164

Merged
merged 1 commit into from
Jan 19, 2019
Merged

Fix: Remove unused test facilities related to removed file argument #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ parameters:
classesAllowedToBeExtended:
- Composer\Command\BaseCommand
ignoreErrors:
- '#Call to deprecated method usingFileArgument\(\) of class Localheinz\\Composer\\Normalize\\Test\\Util\\CommandInvocation.#'
- '#Method Localheinz\\Composer\\Normalize\\Command\\NormalizeCommand::indentFrom\(\) has a nullable return type declaration.#'
paths:
- src
Expand Down
10 changes: 0 additions & 10 deletions test/Util/CommandInvocation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,6 @@ public static function inCurrentWorkingDirectory(): self
return new self('in-current-working-directory');
}

/**
* @deprecated The file argument will be removed in 2.0.0.
*
* @return CommandInvocation
*/
public static function usingFileArgument(): self
{
return new self('using-file-argument');
}

public static function usingWorkingDirectoryOption(): self
{
return new self('using-working-directory-option');
Expand Down
9 changes: 0 additions & 9 deletions test/Util/Scenario.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,6 @@ public function consoleParameters(): array
'command' => 'normalize',
];

if ($this->commandInvocation->is(CommandInvocation::usingFileArgument())) {
return \array_merge($parameters, [
'file' => \sprintf(
'%s/composer.json',
$this->initialState->directory()->path()
),
]);
}

if ($this->commandInvocation->is(CommandInvocation::usingWorkingDirectoryOption())) {
return \array_merge($parameters, [
'--working-dir' => $this->initialState->directory()->path(),
Expand Down