This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Mirroring PR #370 for Interpretations #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @meriouma for the original fix and @gregoryfoster for bringing it up again!
|
@cmc333333, I'm seeing that I cut my branch from a test branch that included your fix for #370. We can either drop your PR, incorporate my commit into your PR, or I'd be happy to re-cut this fix on a standalone branch. |
|
Thanks @gregoryfoster! Keep this up and we'll get you commit access :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #370 fixes the issue with the
content_for_appendix()function inregparser/notice/amendments/appendix.py. The same issue crops up incontent_for_interpretations()ininterpparser/amendments.py:19. This PR mirrors the fix in #370, including a test.