Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Handful of fixes for 37 CFR 42 #357

Merged
merged 10 commits into from
Feb 26, 2017
Merged

Handful of fixes for 37 CFR 42 #357

merged 10 commits into from
Feb 26, 2017

Conversation

cmc333333
Copy link
Member

  • Bugfix for amendments which add a subpart which has sections with subparagraphs
  • Add a SUBPART preprocessor that accounts for a common issue in the XML
  • Fix amendment parsing to prioritize subpart additions over individual sections
  • Make sure notice changes are added in a consistent order (a new issue w/ subpart additions)
  • Add 37 CFR 42 (USPTO) as a regression test

cmc333333 and others added 10 commits February 17, 2017 20:46
@cmc333333
Add interpparser egg to gitignore.
fc6ca37
@cmc333333
Rework notice/changes tests to py.test style.
b41d5a3
@cmc333333
Account for subpart adds with multiple paragraphs
1b2759c 
Previously, we had tacked on the "parent_label" to _all_ subnodes of a subpart
addition. This led all of the nodes to be added at the section level, which
would not only be inaccurate, but lead to an explosion as we couldn't compare
sections (ints) with paragraphs (strings) when sorting.
@cmc333333
Add test around subpart addition.
bfeffaa
@cmc333333
Move/refactor preprocessors_tests.
ef623e0
@cmc333333
Create preprocessor to move SUBPARTs when needed
90e74cf 
The Federal Register notice XML often has little bugs; in this case:

```
<HD SOURCE="HED">
  PART 42—TRIAL PRACTICE BEFORE THE PATENT TRIAL AND APPEAL BOARD
</HD>
<SUBPART>
  <HD SOURCE="HED">Subpart A—Trial Practice and Procedure</HD>
</SUBPART>
<CONTENTS>
  <SECHD>Sec.</SECHD>
  <HD SOURCE="HD1">General</HD>
  <SECTNO>42.1</SECTNO>
  <SUBJECT>Policy.</SUBJECT>
  <SECTNO>42.2</SECTNO>
...
```

Should instead have the SUBPART tag inside the CONTENTS (as in "table of"):
```
<HD SOURCE="HED">
  PART 42—TRIAL PRACTICE BEFORE THE PATENT TRIAL AND APPEAL BOARD
</HD>
<CONTENTS>
  <SUBPART>
    <HD SOURCE="HED">Subpart A—Trial Practice and Procedure</HD>
    <SECHD>Sec.</SECHD>
    <HD SOURCE="HD1">General</HD>
    <SECTNO>42.1</SECTNO>
    <SUBJECT>Policy.</SUBJECT>
    <SECTNO>42.2</SECTNO>
...
```
@cmc333333
Lower section-parsing's plugin order.
b8951c7 
In particular, we want it to fire only if a new subpart can't be found.
@cmc333333
Ensure consistent order for notice changes.
48ab4e2 
This replaces the use of single-keyed dictionaries with a namedtuple of label,
content. I think we should extend this further to represent the change action,
etc. w/ attributes, but wanted to limit the impact for now.

By using these objects (rather than combining dictionaries, we ensure a
consistent ordering.
@cmc333333
Add uspto as a regression test.
be76730
@cmc333333
Add USPTO integration data (37 CFR 42).
c58c673
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 91.92% when pulling c58c673 on cmc333333:320-final-37-42-fixes into 2278cb5 on eregs:master.

@cmc333333 cmc333333 merged commit d0bbfce into eregs:master Feb 26, 2017
@cmc333333 cmc333333 mentioned this pull request Apr 2, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmc333333 @coveralls